Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vmstate to state in getapplicationlog result #665

Open
ixje opened this issue Oct 26, 2021 · 1 comment
Open

Rename vmstate to state in getapplicationlog result #665

ixje opened this issue Oct 26, 2021 · 1 comment

Comments

@ixje
Copy link
Contributor

ixje commented Oct 26, 2021

Summary or problem description
Calling invokefunction, invokescript and invokecontractverify return among others these properties

        "state": "HALT",
        "gasconsumed": "999972",
        "exception": null,
        "stack": [

getapplicationlog has almost the same response, but instead uses vmstate instead of state as the key name for the engine state. Now a consumer has to add special handling just for getapplicationlog while it can all still be considered execution results.

Do you have any solution you want to propose?
I'd like to propose to streamline the naming to state. We can first add state as another key, mention vmstate is deprecated and will be removed in the release after the one the new key is introduced in to avoid breaking existing tools like the getversion change did.

Where in the software does this update applies to?

  • RPC (HTTP) specifically here
@shargon
Copy link
Member

shargon commented Oct 26, 2021

state is good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants