Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugins] Add neo submodule #873

Merged
merged 13 commits into from
Feb 15, 2024
Merged

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Feb 15, 2024

This pr focus on adding the neo core as a submodule of this repo, such that we can adopt the latest update of the core.

* 'master' of github.com:neo-project/neo-modules:
  Fix workflow (neo-project#857)
  Fix stack exception name (neo-project#855)
  update workflow (neo-project#856)
  Refac build configs (neo-project#846)
  Hotfix for neo-project#850 (neo-project#853)
  Fix RpcNativeContract (neo-project#851)
* 'master' of github.com:neo-project/neo-modules:
  Ensure max length (neo-project#845)
  Update .editorconfig and run code analyze (neo-project#866)
  Added AspNetCore (neo-project#863)
  RcpServer: Fixed CORS and Basic Auth (neo-project#812)
  Fix response from getversion due to WS removal (neo-project#859)
  Local dev setup (neo-project#861)
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
@@ -1,76 +0,0 @@
# For most projects, this workflow file will not need changing; you simply need
Copy link
Member

@shargon shargon Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this remove is intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the codeql is not working properly, fixing it should be in another pr, so i just remove it. Or maybe we just remove it, since hte monorepo as a working version.

@shargon shargon self-requested a review February 15, 2024 13:26
@Jim8y Jim8y added the blocker label Feb 15, 2024
@Jim8y Jim8y mentioned this pull request Feb 15, 2024
1 task
@shargon shargon merged commit 7faf535 into neo-project:master Feb 15, 2024
4 of 5 checks passed
@shargon shargon deleted the add-neo-submodule branch February 15, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants