Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure log level #2828

Open
vncoelho opened this issue Nov 2, 2022 · 3 comments
Open

Configure log level #2828

vncoelho opened this issue Nov 2, 2022 · 3 comments
Labels
discussion Initial issue state - proposed but not yet accepted

Comments

@vncoelho
Copy link
Member

vncoelho commented Nov 2, 2022

Maybe it would be good to have a easily configurable parameter for Utility.cs Logger() function.

Changing:

-                Receive<LogEvent>(e => Log(e.LogSource, (LogLevel)e.LogLevel(), e.Message));
+                Receive<LogEvent>(e => Log(e.LogSource, (LogLevel)e.LogLevel(), e.Cause));

Discussing about debugging consensus logs, @ZhangTao1596 suggests that he uses this sometimes, as well as our team.

Receive<LogEvent>(e => Log(e.LogSource, (LogLevel)e.LogLevel(), e.Message));

@vncoelho vncoelho added the discussion Initial issue state - proposed but not yet accepted label Nov 2, 2022
@roman-khimov
Copy link
Contributor

NeoGo always have had a -d CLI parameter to enable debugging, now it also has a configuration file option that allows to set any level desired. It may be useful for C# node as well.

@vncoelho
Copy link
Member Author

@shargon @erikzhang, can you take a look? What is the best way to make this parameter configurable?

@vncoelho
Copy link
Member Author

Maybe use ProtocolSettings directly? What is the best way to configure the Level of this Logger, as an integer and then we set as Message or Cause?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

No branches or pull requests

2 participants