Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP numbers should *not* have decimal parts (e.g. "NEP-5.1") - only whole numbers #50

Closed
mwherman2000 opened this issue Jun 1, 2018 · 10 comments

Comments

@mwherman2000
Copy link
Contributor

mwherman2000 commented Jun 1, 2018

For example, NEX has some extensions to NEP-5 that they want to call NEP-5.1.
@saltyskip has some NFT extensions that I think he wants to call NEP-5.1.
@mwherman2000 (moi) has some NEP-5 extensions for processing remittances ...maybe I want to be the ".1" in NEP-5.1?

I don't think it makes sense to have decimal parts in NEP numbers.

Who has the right to be ".1", who is ".2"? If you're the ".1", do you also have first rights to become ".2" or ".3"? If you're the ".1" and my spec is the ".2" and some other unrelated spec is ".3", will that make sense to anyone 1, 5, 10 years from now?

The whole situation is avoidable if we stick to whole numbers (i.e. positive integers) e.g. NEP-1234

Do you agree?

p.s. Decimal NEP numbers sort of sound like versioning which is also not a good idea and goes against the spirit of NEP-10. If you want a new or different interface, create a new NEP (or NCP).

@mwherman2000
Copy link
Contributor Author

mwherman2000 commented Jun 1, 2018

@mwherman2000 mwherman2000 changed the title NEP numbers should now have decimal parts (e.g. "NEP-5.1") - only whole numbers NEP numbers should *not* have decimal parts (e.g. "NEP-5.1") - only whole numbers Jun 1, 2018
@canesin
Copy link

canesin commented Jun 1, 2018

To give my 2cents @mwherman2000 I think that any standard should be a NEP, so with NEP10 I can say that I comply with NEP5 and NEP15 or whatever and that composed is equivalent to the standard the application need, so the application can call a method and determine if it should process further.

@mwherman2000
Copy link
Contributor Author

@canesin I think I agree with you Fabio (and I'm glad to see you agree with/support NEP-10). I think the key phase in your comment is "any standard should be a NEP" ...and, more importantly, how do we operationalize this?

I've made one suggestion here: #47 (which @erikzhang supports ...I'm looking for others to add their comments).

@canesin
Copy link

canesin commented Jun 1, 2018

@mwherman2000 NEO is a community project already makes no sense for me to have a "NEO Community Proposal" at all, what makes it different then a NEP ? As a matter of fact it is good to have fewer standards.

@mwherman2000
Copy link
Contributor Author

mwherman2000 commented Jun 1, 2018

RE: As a matter of fact it is good to have fewer standards.

Not at all. It may make sense to have fewer (formal) NEP standards but the spirit of NEP-10 is to foster a vibrant developer ecosystem with gazillions of NCPs/NEPs ...trying to say that the only specifications that are shared across the community are the formal NEP specs only serves to stifle innovation in favor of a few large projects.

p.s. If your issue is only with the name (i.e. NEO Community Proposal)... then that's a gentler discussion.

@canesin
Copy link

canesin commented Jun 1, 2018

Is not only the name, I provided some input in the other issue. We cannot have a "stub" to standard.

@mwherman2000
Copy link
Contributor Author

It's whatever works best for the community ...decided by the community.

@canesin
Copy link

canesin commented Jun 1, 2018

We can end up with 100s of NEPs for specific things, that is okay - but a standard need to be static, by definition of standard, you can't comply with NEP5 or NEP10 and that means two different things. So for community standards to work, it should ... be a NEP ?

@erikzhang
Copy link
Member

There won't be a decimal part in a NEP number.

@mwherman2000
Copy link
Contributor Author

Decision (#50 (comment)): "There won't be a decimal part in a NEP number."

Issue closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants