[D2VH2D8O] Only create trigger listeners on system db. #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding listeners to each database can cause nodes from user databases to be removed, as well as cause issues with concurrent drop database commands.
Lojjs
force-pushed
the
dev-drop-database-shutdown
branch
from
1c2aa70
to
4d07879
Compare
ncordon
approved these changes
May 3, 2023
|
Good catch 🚀 . I think we should disregard the failing tests as there seems to be an API that is quite slow that's also failing in 4.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding listeners to each database can cause nodes from user databases to be removed, as well as cause issues with concurrent drop database commands.