[NOID] Annotate unsafe procedures with @NotThreadSafe

[pontusmelke]

[NOID] Annotate unsafe procedures with @NotThreadSafe

Proposed Changes

When run with parallel runtime not all operations on injected instances of Transaction and GraphDatabaseService are supported. By annotating these with @NotThreadSafe we can avoid runtime failures and we detect already at planning that we cannot run these procedures with parallel runtime.

NOTE: the NotThreadSafe annotation has been merged in dev but I guess we need to wait for it to become available?

[ncordon]

What's the criteria to mark something as not thread safe?

For example in coll.min, is it that we are trying to execute a transaction against the slotted runtime?

Is there any way we can test the changes are working correctly and that we haven't missed any annotations that are needed?

[pontusmelke]

What's the criteria to mark something as not thread safe?

For example in coll.min, is it that we are trying to execute a transaction against the slotted runtime?

Is there any way we can test the changes are working correctly and that we haven't missed any annotations that are needed?

Not all operations on injected Transaction or GraphDatabaseService are supported. For example you are not allowed to initiate new transactions nor execute cypher statements when being called from the parallel runtime. So in the case of col.min it is the fact that it uses tx.execute that makes it unsafe to use from parallel runtime.

In order to verify I think we would need to run all tests with all available runtimes but I don't see any easy way of doing this change here.