[NOID] Setups testing for JDK 21 #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncordon
force-pushed
the
jdk-21-testing
branch
3 times, most recently
from
ff905b5
to
8ef7ed2
Compare
ncordon
force-pushed
the
jdk-21-testing
branch
from
8ef7ed2
to
f98d019
Compare
gem-neo4j
reviewed
Nov 10, 2023
| @@ -81,6 +92,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| project: ['common', 'core', 'processor', 'test-utils', 'it'] | |||
| java-version: ['17', '21'] | |||
There was a problem hiding this comment.
I remember there was a reason we had 17.0.8, but not what that reason was, is it no longer a problem?
There was a problem hiding this comment.
Because we had to move it up specifically with a breaking change they did in JDK? But that shouldn't happen hopefully very often
| - uses: ./.github/actions/setup-gradle-cache | ||
| - name: Run tests | ||
| shell: bash | ||
| run: ./gradlew ${{inputs.project-name}}:check --parallel | ||
| run: ./gradlew ${{inputs.project-name}}:test --parallel |
There was a problem hiding this comment.
Is check not needed because we run the other things e.g spotless separately?
There was a problem hiding this comment.
Yes. Because spotless didn't work in f98d019 for Java 21 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to compile with JDK 17 but test with both JDK 17 and JDK 21