[RHMU1hOu] Add tests for RBAC deny on load #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
force-pushed
the
dev_rbac_load_tests
branch
from
e925ca1
to
c2ab875
Compare
Lojjs
requested changes
Mar 5, 2024
| List<String> queries = List.of( | ||
| "CREATE ROLE test", | ||
| "CREATE USER " + user + " SET PASSWORD '" + userP + "' SET PASSWORD CHANGE NOT REQUIRED", | ||
| "GRANT ROLE test, reader, editor TO testUser"); |
There was a problem hiding this comment.
Reader is a subset of editor, so not sure it provides much value to explicitly grant the reader role
There was a problem hiding this comment.
Ah yes, I added these at separate parts in my testing and didn't realise! thanks :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for all loading procedures in APAC to check the deny works well with RBAC rules.
docs: https://github.com/neo4j/docs-apoc/pull/260