Fixing issue #14 #15
Merged
Fixing issue #14 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Actually executing the generated cypher queries in CypherReferenceTest.java to make sure they also compile - Fixing the handling of the ! operators. The generated query must have a space after the ! "WHERE n.prop! = "foo" because cypher fails when != is used as an operator
|
There was already a PR covering many of your issues, I merged that in first. Can you check if that's covering the issues you encountered? Thanks a lot ! |
|
I'll check... But anyway. The unit tests really should execute the cypher statements instead of just comparing them to hardcoded strings. Otherwise you'll never know if they are valid at all... ;-) Maybe it would make sense to merge tbaum's pull request on top of mine... |
Conflicts: src/main/java/org/neo4j/cypherdsl/Literal.java src/main/java/org/neo4j/cypherdsl/query/NullHandling.java src/main/java/org/neo4j/cypherdsl/query/clause/LimitParameterClause.java src/test/java/org/neo4j/cypherdsl/CypherCookbookTest.java src/test/java/org/neo4j/cypherdsl/CypherQueryTest.java src/test/java/org/neo4j/cypherdsl/CypherReferenceTest.java
|
I merged pull request #13 into my pull request. Can you merge it this way? |
|
Done, thanks a lot. |
|
Can you re-add the create unique support, after all it is just a name change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the two bugs described in #14