Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypher filtering - Auth validate #5598

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

mjfwebb
Copy link
Contributor

@mjfwebb mjfwebb commented Sep 27, 2024

Description

This PR fixes a problem where validating against cypher values would cause crash in apoc.util.validatePredicate when the returned value is null

Complexity

Low

Copy link

changeset-bot bot commented Sep 27, 2024

⚠️ No Changeset found

Latest commit: 99c4f47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Sep 27, 2024

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 40 44 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 54 74 1134
aggregations.NestedAggregation 15407 15407 73 90 2174
aggregations.AggregationWithWhere 10833 10833 42 64 2174
aggregations.AggregationWhereWithinNestedRelationships 20097917 20097917 2261 2485 2008534
aggregations.AggregationWhereWithinNestedConnections 20097917 20097917 2231 2303 2008534
aggregations.NestedCountFromMovieToActors 8603 8603 34 42 2174
aggregations.NestedCountFromActorsToMovie 8791 8791 35 40 2174
aggregations.DeeplyNestedCount 10052335 10052335 2794 2493 2008534
aggregations.InterfacesAggregations 6242 6242 44 60 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 76 95 2080
batch-create.BatchCreate 4200 4200 183 164 600
batch-create.BatchCreateSmall 77 77 63 73 11
connect.createAndConnect 6433 6433 149 176 3003
connections.Connection 12951 12951 59 71 2174
connections.NestedConnection 37705 37705 187 146 4516
create.SimpleMutation 7 7 67 65 1
cypher-directive.TopLevelMutationDirective 1135 1135 31 28 1134
delete.SimpleDelete 19401 19401 788 850 1040
delete.NestedDeleteInUpdate 16844 16844 120 152 2040
2871.NestedRelationshipFilter 19869 19856 53 70 4467
2925.SingleRelationshipFilter 5245 5245 36 58 1040
2925.NestedSingleRelationshipFilter 17641 17641 73 104 2174
2925.SingleRelationshipRequiredFilter 5201 5201 40 44 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 51 72 1040
query.SimpleQuery 3121 3121 22 25 1040
query.SimpleQueryWithRelationship 15031 15031 39 43 2174
query.QueryWhere 8594 8594 32 38 2164
query.SimpleQueryWithNestedWhere 8743 8743 45 56 2164
query.Nested 10084891 10084891 9075 7523 2008534
query.NestedWithFilter 10064992 10064992 7159 9120 2004000
query.OrFilterOnRelationships 37363 37169 145 172 2168
query.OrFilterOnRelationshipsAndNested 27439 27603 191 228 2168
query.QueryWithNestedIn 14822 14822 52 71 2074
query.NestedConnectionWhere 8703 8703 52 69 2174
query.DeeplyNestedConnectionWhere 8803 8803 84 90 2174
query.DeeplyNestedWithRelationshipFilters 17489 17489 126 152 1596
query.NestedWithRelationshipSingleFilters 3808 3808 166 208 1134
query.Fulltext 64 64 29 35 16
query.FulltextWithNestedQuery 516 516 39 49 84
sorting-and-cypher.TopLevelSortWithCypher 12961 12961 39 56 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 12961 12961 57 64 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 13096 13096 53 65 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 13096 13096 94 98 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 13700 13700 108 119 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 13266 13266 96 148 2174
sorting.SortMultipleTypes 3436 3436 80 104 1040
sorting.SortMultipleTypesWithCypherWithCypher 13321 13321 97 124 2174
sorting.SortOnNestedFields 12951 12951 58 49 2174
sorting.SortDeeplyNestedFields 39785 39785 82 106 4516
sorting.ConnectionWithSort 3271 3271 78 76 1040
unions.SimpleUnionQuery 321 321 62 60 35
unions.SimpleUnionQueryWithMissingFields 293 293 57 59 35
unions.NestedUnion 309975 309975 262 310 33033
unions.NestedUnionWithMissingFields 283949 283949 258 276 33033
update.NestedUpdate 14137 14137 100 122 2002

Old Schema Generation: 28.810s
Schema Generation: 28.369s
Old Subgraph Schema Generation: 31.037s
Subgraph Schema Generation: 29.381s

@mjfwebb mjfwebb merged commit 42c6e07 into neo4j:dev Sep 27, 2024
79 checks passed
@mjfwebb mjfwebb deleted the cypher-filtering-validate-auth branch September 27, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants