Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket acquisition timeouts #588

Merged
merged 22 commits into from
Feb 25, 2022
Merged

Socket acquisition timeouts #588

merged 22 commits into from
Feb 25, 2022

Conversation

thelonelyvulpes
Copy link
Contributor

No description provided.

@thelonelyvulpes thelonelyvulpes marked this pull request as ready for review February 22, 2022 11:32
@thelonelyvulpes thelonelyvulpes changed the title Feature/socket acquisition Socket acquisition timeouts Feb 23, 2022
AndyHeap-NeoTech
AndyHeap-NeoTech approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution looks good. I particularly like the introduction of the Task extension methods to take a timeout and also handle a CancellationToken correctly. An elegant solution that nicely expands on the original stream extension I added.

@thelonelyvulpes thelonelyvulpes merged commit a4e17ac into 5.0 Feb 25, 2022
@thelonelyvulpes thelonelyvulpes deleted the feature/socket-acquisition branch February 25, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyHeap-NeoTech AndyHeap-NeoTech AndyHeap-NeoTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thelonelyvulpes @AndyHeap-NeoTech