Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Remove default value for required uri property. #20

Closed
michael-simons opened this issue Mar 18, 2020 · 0 comments · Fixed by #21
Closed

Remove default value for required uri property. #20

michael-simons opened this issue Mar 18, 2020 · 0 comments · Fixed by #21
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@michael-simons
Copy link
Contributor

The auto configuration of the driver is conditional:

@ConditionalOnProperty(prefix = "org.neo4j.driver", name = "uri")

We do this so that this starter doesn't clash with the current Spring Data Neo4j starter you get on start.spring.io.

If we would default to localhost, than the user would end up with a connection configured through SDN/OGM and this starter.

If the user adds this starter here, they have to be explicit in configuring the URL.

By doing so, it will than override the auto configuration of SDN/OGM.

Currently, this is not clear, as we a) don't mention it clear enough in the docs and b) default the URL in the properties.

cc @JMHReif

@michael-simons michael-simons added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 18, 2020
@michael-simons michael-simons self-assigned this Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
1 participant