Update sub millisecond transaction timeout handling #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/txtimeout
branch
2 times, most recently
from
42196e8
to
ff14b6c
Compare
injectives
changed the title
injectives
force-pushed
the
feature/txtimeout
branch
2 times, most recently
from
9482041
to
fb197d5
Compare
If transaction timeout value has a sub millisecond value, it gets rounded up to next millisecond value.
injectives
force-pushed
the
feature/txtimeout
branch
from
fb197d5
to
2ce6cdd
Compare
thelonelyvulpes
approved these changes
Jul 11, 2023
...er/src/main/java/org/neo4j/driver/internal/messaging/request/TransactionMetadataBuilder.java
Show resolved
Hide resolved
bigmontz
approved these changes
Jul 11, 2023
...rc/test/java/org/neo4j/driver/internal/messaging/request/TransactionMetadataBuilderTest.java
Show resolved
Hide resolved
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Dec 18, 2023
* Update sub millisecond transaction timeout handling If transaction timeout value has a sub millisecond value, it gets rounded up to next millisecond value. * Add additional test
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Dec 18, 2023
* Update sub millisecond transaction timeout handling If transaction timeout value has a sub millisecond value, it gets rounded up to next millisecond value. * Add additional test
injectives
added a commit
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If transaction timeout value has a sub millisecond value, it gets rounded up to next millisecond value.