Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphId is still used widely in tests and examples. #547

Closed
michael-simons opened this issue Nov 7, 2018 · 2 comments · Fixed by #548
Closed

GraphId is still used widely in tests and examples. #547

michael-simons opened this issue Nov 7, 2018 · 2 comments · Fixed by #548

Comments

@michael-simons
Copy link
Collaborator

The deprecated @GraphId should be removed from the majority of tests and examples.

See also #417 .
michael-simons added a commit that referenced this issue Nov 7, 2018
@michael-simons
GH-547 - Prepare branch.
c049e23
michael-simons added a commit that referenced this issue Nov 7, 2018
@michael-simons
GH-547 - Remove @GraphID from tests.
8119285
@michael-simons michael-simons mentioned this issue Nov 7, 2018
Merged
michael-simons added a commit that referenced this issue Nov 7, 2018
@michael-simons
GH-547 - Polishing.
87409b6
meistermeier pushed a commit that referenced this issue Nov 7, 2018
@michael-simons @meistermeier
GH-547 - Remove @GraphID from tests.
459222f 
Also avoid using the word GraphId in exception messages.
meistermeier pushed a commit that referenced this issue Nov 7, 2018
@michael-simons @meistermeier
GH-547 - Remove @GraphID from tests.
692fd9d 
Also avoid using the word GraphId in exception messages.
@jamesamcl
Copy link

@GraphID is still used on the example at https://neo4j.com/developer/neo4j-ogm/

@michael-simons
Copy link
Collaborator Author

Yes, that's sadly true. Paging @lju-lazarevic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-547 - Remove @GraphID from tests. neo4j/neo4j-ogm
2 participants
@jamesamcl @michael-simons