Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache FieldInfo methods results #853

Closed
nithril opened this issue Oct 21, 2020 · 2 comments
Closed

Cache FieldInfo methods results #853

nithril opened this issue Oct 21, 2020 · 2 comments

Comments

@nithril
Copy link
Contributor

nithril commented Oct 21, 2020 •
edited
Loading

Expected Behavior

In the continuity of the #852, I would suggest to cache the results of the following methods:

  • FieldInfo#relationship

Context

On a project I'm working on we have performance issues. We made the exercise to profile the application to fix the bottleneck.
We have identified the aforementionned methods as responsible of a fraction of the time taken (not negligible).

Please let me know if it makes sense. If so I can submit a pull request.

Your Environment

  • Java version: 1.8.0.265
  • Neo4j version (The version of the database): 3.5.21
  • OGM Version (The version of this software): 3.2.17
  • OGM Transport used (One of Bolt, HTTP or embedded): Bolt
  • Neo4j Java Driver version (in case of Bolt transport): 4.0.2
@meistermeier meistermeier mentioned this issue Oct 23, 2020
Closed
@nithril
Copy link
Contributor Author

nithril commented Oct 23, 2020

Duplicate of #850

@nithril nithril closed this as completed Oct 23, 2020
@nithril nithril reopened this Oct 26, 2020
nithril pushed a commit to nithril/neo4j-ogm that referenced this issue Oct 26, 2020
Cache FieldInfo methods results neo4j#853
2688126
@nithril
Copy link
Contributor Author

nithril commented Oct 26, 2020

I was wrongly expecting #850 to cover FieldInfo

michael-simons pushed a commit that referenced this issue Oct 29, 2020
@nithril
GH-853 - Cache relationship type.
a4dee4f 
This closes #853.

Co-authored-by: labrotni <nicolas.labrot@arhs-spikeseed.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nithril