Select correct string converter. #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We state that `@DateString` can be used both on `java.util.Date` and `java.time.Instant`. However, that is not true: Both underlying converters maybe used, but the annotation picked always the `DateStringConverter`. This change fixes that behaviour and closes #758.
michael-simons
added a commit
that referenced
this pull request
Feb 14, 2020
We state that `@DateString` can be used both on `java.util.Date` and `java.time.Instant`. However, that is not true: Both underlying converters maybe used, but the annotation picked always the `DateStringConverter`. This change fixes that behaviour and closes #758.
michael-simons
added a commit
that referenced
this pull request
Feb 14, 2020
We state that `@DateString` can be used both on `java.util.Date` and `java.time.Instant`. However, that is not true: Both underlying converters maybe used, but the annotation picked always the `DateStringConverter`. This change fixes that behaviour and closes #758.
michael-simons
added a commit
that referenced
this pull request
Feb 14, 2020
michael-simons
added a commit
that referenced
this pull request
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We state that
@DateStringcan be used both onjava.util.Dateandjava.time.Instant. However, that is not true: Both underlying converters maybe used, but the annotation picked always theDateStringConverter. This change fixes that behaviour and closes #758.