Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensures no queries on new objects #1597

Merged
merged 2 commits into from
Apr 5, 2020
Merged

ensures no queries on new objects #1597

merged 2 commits into from
Apr 5, 2020

Conversation

klobuczek
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 5, 2020

Codecov Report

Merging #1597 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1597      +/-   ##
==========================================
+ Coverage   93.79%   93.91%   +0.11%     
==========================================
  Files         126      126              
  Lines        5758     5735      -23     
==========================================
- Hits         5401     5386      -15     
+ Misses        357      349       -8     
Impacted Files Coverage Δ
lib/active_graph/core/label.rb 82.53% <ø> (+5.51%) ⬆️
lib/active_graph/shared.rb 88.46% <ø> (+1.79%) ⬆️
lib/active_graph/core/query.rb 98.96% <100.00%> (ø)
lib/active_graph/node/has_n.rb 98.84% <100.00%> (-0.40%) ⬇️
lib/active_graph/node/query/query_proxy.rb 96.25% <100.00%> (+1.15%) ⬆️
lib/active_graph/node/unpersisted.rb 100.00% <100.00%> (ø)
lib/active_graph/relationship/query.rb 95.83% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3bda5...0245daa. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Apr 5, 2020

Code Climate has analyzed commit 0245daa and detected 0 issues on this pull request.

View more on Code Climate.

@klobuczek klobuczek merged commit 8ed9824 into master Apr 5, 2020
@klobuczek klobuczek deleted the queries_on_new_objects branch April 5, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants