Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specify column(s) to touch #1603

Closed
wants to merge 2 commits into from
Closed

Allow specify column(s) to touch #1603

wants to merge 2 commits into from

Conversation

JacobGalati
Copy link

Fixes #

This pull introduces/changes:

  • Implementing similar touch functionality to ActiveRecord
  • Allows specifying column(s) to touch in addition to updated_at.
  • If no attributes are passed, it will simply touch updated_at

codeclimate[bot]
codeclimate bot reviewed May 5, 2020
View reviewed changes
lib/active_graph/shared/persistence.rb Outdated Show resolved Hide resolved
lib/active_graph/shared/persistence.rb Outdated Show resolved Hide resolved
@JacobGalati
Copy link
Author

ActiveRecord's touch does not trigger update callbacks, but ActiveGraph does.
I was considering changing that as well, but that would introduce backwards compatibility issues.

@codeclimate
Copy link

codeclimate bot commented May 5, 2020

Code Climate has analyzed commit a4844a2 and detected 0 issues on this pull request.

View more on Code Climate.

@JacobGalati JacobGalati closed this by deleting the head repository Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JacobGalati