Issue-1611 Fix in updating relations with ids #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1612 +/- ##
=========================================
Coverage ? 94.02%
=========================================
Files ? 126
Lines ? 5721
Branches ? 0
=========================================
Hits ? 5379
Misses ? 342
Partials ? 0
Continue to review full report at Codecov.
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| end.compact | ||
| end | ||
|
|
||
| def delete_rels_for_nodes(ids) | ||
| def delete_rels_for_nodes(original_ids, node_or_nodes) |
There was a problem hiding this comment.
Method delete_rels_for_nodes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit 30171e9 and detected 0 issues on this pull request. View more on Code Climate. |
klobuczek
approved these changes
Jul 27, 2020
| @@ -49,31 +49,20 @@ def delete_all_rels | |||
| # Deletes the relationships between all nodes for the last step in the QueryProxy chain and replaces them with relationships to the given nodes. | |||
| # Executed in the database, callbacks will not be run. | |||
| def replace_with(node_or_nodes) | |||
| node_hash = idify_hash(node_or_nodes) | |||
| node_or_nodes = Array(node_or_nodes).map { |arg| arg.is_a?(ActiveGraph::Node) ? arg : @model.find(arg) } | |||
There was a problem hiding this comment.
Suggested change
| node_or_nodes = Array(node_or_nodes).map { |arg| arg.is_a?(ActiveGraph::Node) ? arg : @model.find(arg) } | |
| nodes = Array(node_or_nodes).map { |arg| arg.is_a?(ActiveGraph::Node) ? arg : @model.find(arg) } |
This is guaranteed to be an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1611
This pull introduces/changes:
In case there was a string ID property, the
to_ion passed id parameter would cause it be inconsistent with IDs of existing relations and we would end up with deleting all existing relations.