ENV-based login/pass/encryption set #1643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add possibility to set login, password, encryption for using migration in non-Rails projects
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -7,9 +7,12 @@ if !defined?(Rails) && !Rake::Task.task_defined?('environment') | |||
| task :environment do | |||
| require 'ostruct' | |||
| neo4j_url = ENV['NEO4J_URL'] || 'bolt://localhost:7687' | |||
| neo4j_user = ENV['NEO4J_USER'] || 'neo4j' | |||
| neo4j_password = ENV['NEO4J_PASSWORD'] || 'neo4j' | |||
| neo4j_encryption = ENV['NEO4J_ENCRYPTION'] == 'true' ? true : false | |||
There was a problem hiding this comment.
This conditional expression can just be replaced by ENV['NEO4J_ENCRYPTION'] == 'true'.
|
Code Climate has analyzed commit aca9026 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Thanks @EugeneIstomin . Have you considered extracting this https://github.com/neo4jrb/activegraph/blob/master/lib/active_graph/railtie.rb#L82-L85 out of railtie.rb? There are many configuration options. Creating an environment variable each time someone needs one of those options doesn't seem like a sustainable solution. It would be great to solve the problem for any possible configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull introduces/changes: