Fail on schema response HTTP error #313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running neo4j:migrate and the call returns an unexpected error, e.g. (502 - Bad Gateway), the following error is returned:
neo4j-core-8.1.2/lib/neo4j/core/cypher_session/adaptors/http.rb:69 constraints
NoMethodError: undefined method `map' for #String:0x000000000917c6a0
This is due to the fact that only structured errors are being handled.
In order to facilitate debugging, this PR fails on any HTTP error that might occur during that process.
I'm not sure if the
:errors
key can be present even if the result is a success, so i left the logic separated.Pings:
@cheerfulstoic
@subvertallchris