Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail schema inspection when full text indexes exist #338

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Don't fail schema inspection when full text indexes exist #338

wants to merge 3 commits into from

Conversation

imustafin
Copy link

@imustafin imustafin commented Jan 22, 2020

This pull introduces/changes:

  • Using Cypher queries instead of /db/data/schema/index endpoint for getting indexes and constraints in Neo4j >= 3.0.0 (since addition of the CALL clause)
  • Schema validation doesn't fail when full text indexes exist by ignoring such indexes

This PR is needed to allow using neo4j-core when full text indexes exist, without this PR schema validation fails as they appear as INDEX ON NODE:Label(key) instead of INDEX ON :Label(key) in db.indexes (more of the discussion: https://gitter.im/neo4jrb/neo4j?at=5e1efa848b53f6190ab79919).

This PR doesn't add any additional support for such indexes.

@coveralls
Copy link

coveralls commented Jan 22, 2020

Coverage Status

Coverage decreased (-3.7%) to 86.97% when pulling aada171 on imustafin:master into 4b649fc on neo4jrb:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.3%) to 86.327% when pulling 3839629 on imustafin:master into 4b649fc on neo4jrb:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.3%) to 86.327% when pulling 3839629 on imustafin:master into 4b649fc on neo4jrb:master.

@imustafin imustafin changed the title Don't fail schema inspection when legacy (or full text) indexes exist Don't fail schema inspection when full text indexes exist Jan 22, 2020
@imustafin
Copy link
Author

I need help with jruby builds on Travis. I don't know how to fix them.

@imustafin imustafin marked this pull request as ready for review January 22, 2020 06:26
@amitsuryavanshi
Copy link
Member

@imustafin Can you make this PR against 10.0.x branch? That branch is going to be master soon. Thanks.

@imustafin
Copy link
Author

@amitsuryavanshi I don't see the 10.0.x branch (https://github.com/neo4jrb/neo4j-core/branches/all). The newest branches I see are master and 9.0.x.

@amitsuryavanshi
Copy link
Member

@imustafin Pardon me, its for neo4jrb.
Can you check neo4jrb 10.0.x branch if it is using neo4j-core. I assume its going to be removed from dependency. https://github.com/neo4jrb/neo4j/pull/1575/files

@imustafin
Copy link
Author

@amitsuryavanshi I see that neo4j-core is moving to neo4j. I will make another PR to neo4j branch 10.0.x. What will happen to this PR to neo4j-core?

@amitsuryavanshi
Copy link
Member

@imustafin Let this be open. We yet to decide on what to do with neo4j-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants