Adding support for multiple AWS secrets to be connected #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
+ Coverage 90.00% 91.00% +1.00%
==========================================
Files 11 12 +1
Lines 90 100 +10
Branches 17 17
==========================================
+ Hits 81 91 +10
Misses 9 9
|
iansu
requested changes
Oct 17, 2020
iansu
requested changes
Oct 17, 2020
Co-authored-by: Ian Sutherland <ian@iansutherland.ca>
iansu
approved these changes
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing AWS_SECRETS_MANAGER_NAME to either be a string or a list of strings.
If a list of strings is provided it will connect each AWS Secrets bucket and merge all the configs from each one into a single config object. The list is processed in order, meaning buckets including later in the list take priority of previous buckets in the case where a config exists in both buckets.