Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CH-16094: Fix exemptUsers bug #8

Merged
merged 25 commits into from
Jul 21, 2020
Merged

CH-16094: Fix exemptUsers bug #8

merged 25 commits into from
Jul 21, 2020

Conversation

pqt
Copy link
Contributor

@pqt pqt commented Jul 20, 2020

Clubhouse Link

CH-16094

Description of changes

  • This fixes a bug in ticket-check-action where it was looking at the wrong field when looking up exempt users.

  • Improved debugging for the future. If we set a secret in a repo running into problems this, will help us identify anything that's wrong almost immediately now.
    Setting ACTIONS_STEP_DEBUG to true will activate/enable all of the debug() function contents to get logged.

Once this is merged, tagged and released, the only requirement will be to re-run all past jobs that failed. They should pass next time.

@pqt pqt requested review from iansu and Lewis65 and removed request for iansu July 20, 2020 08:01
@pqt pqt marked this pull request as ready for review July 20, 2020 08:01
iansu
iansu previously approved these changes Jul 20, 2020
Copy link
Member

@iansu iansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Make sure you update the CHANGELOG and version number.

@pqt pqt merged commit 28fa8a1 into master Jul 21, 2020
@pqt pqt deleted the ch16094/exempt-users-bug branch July 21, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants