Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version 1.19.x #44

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Remove version 1.19.x #44

merged 3 commits into from
Jan 4, 2024

Conversation

Imzxhir
Copy link
Contributor

@Imzxhir Imzxhir commented Jan 3, 2024

Description: This PR removes version 1.19.x from the NeoForge Documentation. This is because the version is not used and was clearly generated automatically with the default content for a new version.

This can be seen here: https://docs.neoforged.net/docs/1.19.x/intro

Note: I was not able to test the PR since I was having issues with npm and it not working when trying to start the local server.


Preview URL: https://pr-44.neoforged-docs-previews.pages.dev

@ChampionAsh5357
Copy link
Contributor

You need to remove the 1.19 mentions in the configurations as well.

@Imzxhir
Copy link
Contributor Author

Imzxhir commented Jan 4, 2024

I was able to test this PR locally and can confirm that it removes the 1.19.x version completely.

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) January 4, 2024 18:19 Active
@neoforged-pages-deployments
Copy link

Deploying with Cloudflare Pages

Name Result
Last commit: 5c672d9f1b4106864946813490066679718b9c71
Status: ✅ Deploy successful!
Preview URL: https://7b974bfb.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-44.neoforged-docs-previews.pages.dev

Copy link
Contributor

@ChampionAsh5357 ChampionAsh5357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ChampionAsh5357 ChampionAsh5357 merged commit c38895f into neoforged:main Jan 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants