-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java Core Mods #79
Conversation
We do not have generics for |
@Technici4n You will notice that it did compile (yes, yes, license violation...) with FML head, so I think we do ;-) |
Ah, yes we do. Didn't read why the build was failing. 😁 Good idea in any case. We can change the interface later but for now this is good enough. I also expect noticeable startup time improvements once we move the NF coremods to this. |
Last commit published: 02c2e73818ad66a22dc348a98201c0259e749451. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #79' // https://github.com/neoforged/FancyModLoader/pull/79
url 'https://prmaven.neoforged.net/FancyModLoader/pr79'
content {
includeModule('net.neoforged.fancymodloader', 'junit-fml')
includeModule('net.neoforged.fancymodloader', 'loader')
includeModule('net.neoforged.fancymodloader', 'earlydisplay')
}
}
} |
@shartte, this PR introduces breaking changes.
|
loader/src/main/java/net/neoforged/fml/loading/CoreModScriptLoader.java
Outdated
Show resolved
Hide resolved
loader/src/main/java/net/neoforged/fml/loading/FMLServiceProvider.java
Outdated
Show resolved
Hide resolved
Mods must ship a separate Jar-file (for example via jar-in-jar) and mark it as FMLModType: LIBRARY to make it load above the GAME layer. They then must provide an implementation of ICoreMod via the Java ServiceLoader to contribute their transformers.
…o also covert that Added coremod tests
loader/src/main/java/net/neoforged/fml/loading/FMLServiceProvider.java
Outdated
Show resolved
Hide resolved
…der.java Co-authored-by: Matyrobbrt <65940752+Matyrobbrt@users.noreply.github.com>
Mods must ship a separate Jar-file (for example via jar-in-jar) and mark it as FMLModType: LIBRARY to make it load above the GAME layer. They then must provide an implementation of ICoreMod via the Java ServiceLoader to contribute their transformers.
This tries to avoid loading the script-engine based coremod library unless any modfile contains such coremod scripts.