Provide a MDK version using ModDevGradle #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelanX
reviewed
Jun 19, 2024
build.gradle
Outdated
| systemProperty 'forge.enabledGameTestNamespaces', project.mod_id | ||
| programArgument '--nogui' | ||
| } | ||
| // accessTransformers.add(rootProject.file('src/main/resources/META-INF/accesstransformer.cfg')) |
There was a problem hiding this comment.
You need a string here, not a file. At least with moddev 0.1.94, didn't test the version here (0.1.74).
There was a problem hiding this comment.
Yes, now with Gradle 8.8 released, we can actually make this just a normal file collection.
Previously it was impossible to set defaults for file collections (and we wanted the default location to work without config)
Matyrobbrt
changed the title
Matyrobbrt
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the MDK to utilize ModDevGradle (MDG), which is currently in a Work-In-Progress (WIP) state. The purpose of this PR is to showcase the migration process from a NeoGradle-based project to one that incorporates MDG.