Remove CommonHooks#getBurnTime and move contents to ItemStack#getBurnTime
#699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ChampionAsh5357
previously requested changes
Mar 10, 2024
src/main/java/net/neoforged/neoforge/common/extensions/IItemStackExtension.java
Show resolved
Hide resolved
|
This PR is for 1.20.5, not 1.20.4 @ChampionAsh5357. |
Matyrobbrt
added
cleanup
|
oh shit, was experimenting and forgot to remove this. will delete some of this tmrw so STOP yelling at me. Thank you. |
src/main/java/net/neoforged/neoforge/common/extensions/IItemStackExtension.java
Outdated
Show resolved
Hide resolved
….com/Spinoscythe/NeoForge into issuefix/remove-commonhooks-burntime
…//github.com/Spinoscythe/NeoForge into issuefix/remove-commonhooks-burntime" This reverts commit 5ed95b6, reversing changes made to 9e6c364.
Spinoscythe
changed the title
CommonHooks#getBurnTime and move contents to ItemStack#getBurnTimeCommonHooks#getBurnTime and move contents to ItemStack#getBurnTime
Shadows-of-Fire
requested changes
Apr 3, 2024
patches/net/minecraft/world/level/block/entity/AbstractFurnaceBlockEntity.java.patch
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/extensions/IItemStackExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/extensions/IItemExtension.java
Outdated
Show resolved
Hide resolved
Shadows-of-Fire
previously approved these changes
Apr 4, 2024
Spinoscythe
changed the title
CommonHooks#getBurnTime and move contents to ItemStack#getBurnTimeCommonHooks#getBurnTime and move contents to ItemStack#getBurnTime
Shadows-of-Fire
approved these changes
Apr 4, 2024
Shadows-of-Fire
added
1.20.4
ApexModder
pushed a commit
to ApexModder/NeoForge
that referenced
this pull request
May 3, 2024
…ack#getBurnTime` (neoforged#699)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do I do shit like this... Redo of #633 due to git complexities. Extremely sorry for any inconvenience.
Fixes #632
Previously approved by: