Push Popup

[TimUntersberger]

Actions

• Push to pushremote
• Push to upstream
• Push to branch

[tomaskallup]

Ah I was wondering why the push isn't working at all, is this something I could perhaps help with? This seems to be open for quite some time and for me even the pushremote isn't working.

[RianFuro]

@tomaskallup
Push should be working as long as a remote is already set up. I admit it's pretty bare bones right now though. Also upstream and pushremote do the same thing currently and there is no way to set either from neogit.
You're welcome to help out if you want to :) The relevant parts are in popups/push.lua and lib/git/push.lua. We do want to take over the upstream/pushremote distinction from magit and some prompts to dynamically set the upstream when necessary are definitely needed.

[tomaskallup]

I think I found the issue, on my end I have a huge file in the repo (97MB) and the push takes a long time. It would be nice to have some sort of progress bar or a loader to indicate, that the push is still ongoing.

[RianFuro]

Totally agree; as I said, pretty bare bones 😅

[itmecho]

We do want to take over the upstream/pushremote distinction from magit and some prompts to dynamically set the upstream when necessary are definitely needed

Am I right in thinking this would allow you to create a new local branch and then push it up to remote when it doesn't exist? i.e.git checkout -b my-new-branch && git push --set-upstream origin my-new-branch

At the moment I create the branch with neogit but then run the git push manually

[TimUntersberger]

@itmecho no it would use the upstream but not set it up. Tbh I also think the current implementation is a bit annoying, but I don't really know how to do this correctly yet.

[itmecho]

Hmm I was trying to think of how I would do it. Best I came up with was a new option in the push popup for "push and set upstream", then prompt for the remote name (or if there is only one just use that) and then prompt for the remote branch name (which could pre-populate with the current branch name). Those could also be set as defaults in the config.

That's just my use case though, not sure how it would fit in with other people's =\

[itmecho]

Hacky version which "worked on my machine"

master...itmecho:proto/set-upstream

[TimUntersberger]

@itmecho I added a switch to the push popup in #131.

[DemonInTheCloset]

Hi, I am not sure if I should say this here, but could you add a --tags flag for the push popup?

[mcepl]

For explanation why there are two https://magit.vc/manual/magit.html#The-Two-Remotes but still doesn’t make sense to me. IMHO, feature branch should never know what its final destination will be and should only be push to my-fork/feature. Whole merging (be it done with pull/merge-requests or via git send-email) should be outside of the local git operations.

[practicalli-johnny]

I work on many open source projects and set the origin name to the GitHub organisation or user account name, so I know where I am pushing too

It would be very useful to set where neogit pushes to when using p from the push menu

Currently I use e for elsewhere and type in the origin name I use for that repository.

I assume the value of the origin can be ascertained from the local Git repository.

[CKolkey]

Agreed! I'll be upstreaming some changes that should solve for this with some ability to set git config values

(you can use my fork for now if you don't want to wait)

[ten3roberts]

Not knowing what you're force pushing to is part of the fun, especially when reviewing pull requests.

Jokes aside, as @CKolkey mentioned we are soon to upstream a lot of QOL improvements to neogit which will for example include better push.