Use Buffers in Auto-Completion #3899
Closed
flatcap
started this conversation in
Development
Replies: 2 comments
-
This has been done in 02a97ee and can be closed right? |
Beta Was this translation helpful? Give feedback.
0 replies
-
Yes. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Here's the layout of functions in Auto-Completion:
Source: graphviz, svg
On the left,
buf_get_field()
and its 66 callers take astruct Buffer
parameter.Everything to the right needs converting.
Spoiler
Start by changing the
EnterWindowData
to use both aBuffer
andchar*
(they'd point to the same memory).This would allow you to convert each of the Editor's functions as a separate commit.
e.g.
<op_editor_complete>
/op_editor_complete()
.The
complete_*()
functions takeEnterWindowData
, so they will only need tweaking as you convert the actual completion functions, on the right.Beta Was this translation helpful? Give feedback.
All reactions