Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solves issue #706 #840

Merged
merged 18 commits into from
Feb 19, 2022
Merged

solves issue #706 #840

merged 18 commits into from
Feb 19, 2022

Conversation

deepanshu44
Copy link
Contributor

@deepanshu44 deepanshu44 commented Jan 6, 2022 •
edited
Loading

create-neon now deletes the partial project directory on a non-zero exit
#706

@deepanshu44 deepanshu44 marked this pull request as draft January 6, 2022 10:22
@deepanshu44 deepanshu44 marked this pull request as ready for review January 6, 2022 10:52
kjvalencik
kjvalencik requested changes Jan 10, 2022
View reviewed changes
create-neon/src/shell.ts Outdated Show resolved Hide resolved
create-neon/src/bin/create-neon.ts Show resolved Hide resolved
create-neon/src/bin/create-neon.ts Show resolved Hide resolved
create-neon/src/bin/create-neon.ts Outdated Show resolved Hide resolved
create-neon/src/bin/create-neon.ts Outdated Show resolved Hide resolved
create-neon/src/shell.ts Outdated Show resolved Hide resolved
create-neon/src/shell.ts Outdated Show resolved Hide resolved
create-neon/src/shell.ts Outdated Show resolved Hide resolved
create-neon/src/shell.ts Outdated Show resolved Hide resolved
create-neon/src/shell.ts Show resolved Hide resolved
kjvalencik
kjvalencik requested changes Jan 11, 2022
View reviewed changes
cli/src/async/child_process.ts Outdated Show resolved Hide resolved
create-neon/src/bin/create-neon.ts Outdated Show resolved Hide resolved
create-neon/src/bin/create-neon.ts Outdated Show resolved Hide resolved
create-neon/src/bin/create-neon.ts Outdated Show resolved Hide resolved
create-neon/src/bin/create-neon.ts Outdated Show resolved Hide resolved
create-neon/src/bin/create-neon.ts Outdated Show resolved Hide resolved
@kjvalencik
Copy link
Member

Thanks for all your hard work on this!

@kjvalencik kjvalencik merged commit 492a541 into neon-bindings:main Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjvalencik kjvalencik kjvalencik requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepanshu44 @kjvalencik