Fix panic during shutdown when using channel #934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rf-figma
force-pushed
the
fix-channel-panic
branch
from
bc81fe4
to
2bf1525
Compare
This fixes a bug that can be triggered when there's a JsBox holding an instance of Channel at the moment the VM stops (e.g., when quitting an Electron app). The Channel's `drop` implementation calls `self.send`, which panics with a SendError because we're already in the middle of tearing everything down.
This fixes a sporadic panic caused by a race condition between a Worker loading our test-specific Rust extension and the worker being shut down. This shouldn't panic in principle, but fixing it would require introducing a leak (see 2bf1525 for the change we could have made and decided not to).
rf-figma
force-pushed
the
fix-channel-panic
branch
from
2bf1525
to
c0330a3
Compare
kjvalencik
reviewed
Nov 8, 2022
| setTimeout(cb, 100); | ||
| worker.once("message", async () => { | ||
| await worker.terminate(); | ||
| cb(); |
There was a problem hiding this comment.
I believe this still needs to be delayed a bit for the race, but to be honest, I don't exactly remember the ordering of this test.
|
Merged via 000b6c5 |
kjvalencik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the revert of #932, adding a second commit that should fix a related race condition that was causing a build failure.