💄 Replace the search button with a magnifying glass #483
Conversation
…image of any size to button, change bar.rs to set image
There was a problem hiding this comment.
Thanks ❤️ for working on this PR. We really appreciate it 👍 everything looks good but I think the magnifying glass color might not work on dark colorschemes like for example I think it might become invisible on colorscheme like dark-chocolate. So I would suggest using a magnifying glass image of different color or maybe you can also change the image dynamically by taking the svg code and putting it in the HTML file directly and then changing the fillproperty of svg image to change image colors dynamically. 🙂
|
Thaks for such positive feedback, but I'm not clear about color change. I've checked all themes with black color. So if I need to change image color, what color I need to pick? Dark Chocolate
Solarized DarK
Tomorrow Night
Tokyo Night
|
After through testing, all the color schemes on our side. We found that the icon you have chosen works on all the color schemes, and as such we would suggest leaving the icon as it is. 🙂 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
What does this PR do?
This pr improve design of search bar with replacing search button with magnification glass.
Why is this change important?
Improve UI, make it look more modern, improve the user experience
Related issues
Closes #450