Discord sync #1
Closed
Discord sync #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaggyos
commented
Mar 2, 2017
shaggyos
commented
- Pull request updates sink/init.py to resolve frozen route issue (already addressed in hangoutsbot/master
- Updated instructions in both discord.py as well as creating DISCORD.md.
move requesthandler.addroute(app.router) above hander = app.make_handler(). This applied the fix for a known issue related to "frozen route" errors Discussed in hangoutsbot/pull/655/commits/8192f7a4573b091ab86606624cdfe45e120d669b
Updated the instructions to clarify a couple of points, and make it easier for people new to discord to successfully create a discord/hangouts bot. No changes made to routines/code.
Created document detailing steps to create a discord bot, configure and link to hangouts. Suitable for someone not familiar with Discord setup.
neon-ninja
requested changes
Mar 2, 2017
There was a problem hiding this comment.
The frozen route fix (https://github.com/neon-ninja/hangupsbot/pull/1/files/dd0753072ca8d8476eb0644ab94c2d68c7f02205#diff-978eca6b160200863f9de580e66a3719R148) seems outside the scope of the upstream discord_sync pull request
neon-ninja
requested changes
Mar 2, 2017
There was a problem hiding this comment.
There seem to be a lot of � characters in DISCORD.md. Most concerningly, you advise people to surround their discord token with � on line 48 (dd07530#diff-90a5bb4c1729154b620d537e208170c5R48)
|
Oops! Must be some Unicode chars from the copy paste from my original
attempt to update.
I'll go through and fix it up.
…On 3 Mar 2017 9:21 AM, "Nick Young" ***@***.***> wrote:
***@***.**** requested changes on this pull request.
There seem to be a lot of � characters in DISCORD.md. Most concerningly,
you advise people to surround their discord token with � on line 48 (
dd07530#diff-90a5bb4c1729154b620d537e208170c5R48
<dd07530#diff-90a5bb4c1729154b620d537e208170c5R48>
)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOU-aZPv5oiehSE5pr6RRm7mvP9_-D44ks5rh074gaJpZM4MRGwp>
.
|
Remove unusual unicode characters.
|
I've cherry picked your commits and added them to my discord_sync branch, so they're now showing in my upstream PR at hangoutsbot#636 I did it that way because I expect c2f1375 would have a merge conflict with hangoutsbot@8192f7a Thanks for contributing! |
neon-ninja
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.