Add storage-controller service
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
force-pushed
the
jcsp/storage-controller-pt1
branch
3 times, most recently
from
0948a63
to
ca2080b
Compare
It needs a database to run.
jcsp
force-pushed
the
jcsp/storage-controller-pt1
branch
from
e1903c6
to
68cc54f
Compare
cicdteam
reviewed
Feb 2, 2024
jcsp
force-pushed
the
jcsp/storage-controller-pt1
branch
from
4fc5c6f
to
c2b7fcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR paves the way to deploy this service into staging, for the next stage of integration and test for sharding:
This is the first PR that makes a concrete naming choice for the service:
storage-controllerfeels like a reasonably descriptive and future-proof name for what this service does, and aligns with the existingstorage-brokerservice. This piece of code is currently calledattachment_servicein the neon.git tree for historical reasons, and has recently been called "sharding service" in the context of its role in getting pageserver sharding deployed.Via: https://github.com/neondatabase/cloud/issues/9718