Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

race condition where we lose some incremental logical size updates #6023

Open
problame opened this issue Dec 4, 2023 · 0 comments
Open

race condition where we lose some incremental logical size updates #6023

problame opened this issue Dec 4, 2023 · 0 comments
Labels
c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions

Comments

@problame
Copy link
Contributor

problame commented Dec 4, 2023

We're losing the size deltas sent to update_current_logical_size() in the time window starting from when initial logical size calculation .load()s the current added to the point where it does initial_logical_size.set().

Originally posted by @problame in #6000 (comment)

Issue still stands after #6000
@problame problame added c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions labels Dec 4, 2023
@problame problame mentioned this issue Dec 4, 2023
Merged
problame added a commit that referenced this issue Dec 4, 2023
@problame
remove TODO, turned into follow-up #6023
08b65dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/storage/pageserver Component: storage: pageserver m/good_first_issue Moment: when doing your first Neon contributions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@problame