-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neon extension did not get auto-upgraded #7003
Comments
likely due to |
Stas: It affects cold start times if we upgrade the extension on every start. Anastasia: Introduce flag if compute version changes, then roll upgrade. |
Will solve this specific problem by either introducing a new flag on the cloud side, or do an always-enabled migration on the compute side. The broader problem is tracked in #6936. |
## Problem Fix #7003. Fix #6982. Currently, neon extension is only upgraded when new compute spec gets applied, for example, when creating a new role or creating a new database. This also resolves `neon.lfc_stat` not found warnings in prod. ## Summary of changes This pull request adds the logic to spawn a background thread to upgrade the neon extension version if the compute is a primary. If for whatever reason the upgrade fails, it reports an error to the console and does not impact compute node state. This change can be further applied to 3rd-party extension upgrades. We can silently upgrade the version of 3rd party extensions in the background in the future. Questions: * Does alter extension takes some kind of lock that will block user requests? * Does `ALTER EXTENSION` writes to the database if nothing needs to be upgraded? (may impact storage size). Otherwise it's safe to land this pull request. Signed-off-by: Alex Chi Z <chi@neon.tech>
Steps to reproduce
Expected result
Upgraded to 1.3 on prod
Actual result
Stay at 1.1
Environment
Logs, links
The text was updated successfully, but these errors were encountered: