Persist safekeeper control file once in a while. #4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanyp
reviewed
Jun 7, 2023
arssher
force-pushed
the
sk-persist-cf-regularly
branch
from
4bbdf40
to
cedb749
Compare
It should make remote_consistent_lsn commonly up-to-date on non actively writing projects, which removes spike or pageserver -> safekeeper reconnections on storage nodes restart.
arssher
force-pushed
the
sk-persist-cf-regularly
branch
from
cedb749
to
f3454b0
Compare
shanyp
approved these changes
Jun 7, 2023
petuhovskiy
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
This may help with #4414, but I think we still need to persist control file on disconnect and also persist commit_lsn and other fields as well. Can be done in another PR.
|
Ok, but note that commit_lsn is also persisted here. |
Right, I mixed up |
1000 tests run: 959 passed, 0 failed, 41 skipped (full report)The comment gets automatically updated with the latest test results
f3454b0 at 2023-06-07T10:01:40.742Z :recycle: |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should make remote_consistent_lsn commonly up-to-date on non actively writing projects, which removes spike or pageserver -> safekeeper reconnections on storage nodes restart.