Do not attach deleted tenants #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LizardWizzard
changed the title
1608 tests run: 1535 passed, 0 failed, 73 skipped (full report)The comment gets automatically updated with the latest test results
9a7bf79 at 2023-08-17T10:24:06.620Z :recycle: |
Rather temporary solution before proper: #5006 it requires more plumbing so lets not attach deleted tenants first and then implement resume.
LizardWizzard
force-pushed
the
dkr/do-not-attach-deleted-tenants
branch
from
d6a3b00
to
2da0e6a
Compare
|
|
shanyp
approved these changes
Aug 17, 2023
LizardWizzard
force-pushed
the
dkr/do-not-attach-deleted-tenants
branch
from
aa8eb19
to
9a7bf79
Compare
koivunej
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather temporary solution before proper:
#5006
It requires more plumbing so lets not attach deleted tenants first and then implement resume.
Additionally update
assert_prefix_emptyto match introducedpageserversuffix.Resolves #5016