-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy: add http2 support #6335
Closed
Closed
proxy: add http2 support #6335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2256 tests run: 2171 passed, 0 failed, 85 skipped (full report)Flaky tests (3)Postgres 15Postgres 14
Code coverage (full report)
The comment gets automatically updated with the latest test results
2430612 at 2024-01-12T18:50:56.164Z :recycle: |
can we have tests that websocket works on http1.1 and http2? |
Adding a WS over HTTP2 test will be tricky. Waiting on encode/httpx#304 + encode/httpcore#592.
|
conradludgate
added a commit
that referenced
this pull request
Feb 20, 2024
## Problem Proxy already supported HTTP2, but I expect no one is using it because we don't advertise it in the TLS handshake. ## Summary of changes #6335 without the websocket changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Proxy already supported HTTP2, but I expect no one is using it because we don't advertise it in the TLS handshake.
WebSockets over HTTP2 is a different story and we need more explicit handling of it. Thankfully the protocol is exactly the same, just the handshake is different.
Summary of changes
Checklist before requesting a review
Checklist before merging