-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(walredo): split up walredo.rs
#6583
Merged
problame
merged 12 commits into
main
from
problame/2024-02-walredo-work/prespawn/split-code
Feb 6, 2024
Merged
refactor(walredo): split up walredo.rs
#6583
problame
merged 12 commits into
main
from
problame/2024-02-walredo-work/prespawn/split-code
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2388 tests run: 2273 passed, 0 failed, 115 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
05f3d70 at 2024-02-05T13:23:40.149Z :recycle: |
This was referenced Feb 2, 2024
VladLazar
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but clippy has a complaint:
error: unused import: `atomic::AtomicUsize`
--> pageserver/src/walredo/process.rs:17:12
|
17 | sync::{atomic::AtomicUsize, Mutex, MutexGuard},
| ^^^^^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`
problame
changed the title
refactor(walredo): split up the massive
refactor(walredo): split up Feb 6, 2024
walredo.rs
walredo.rs
problame
deleted the
problame/2024-02-walredo-work/prespawn/split-code
branch
February 6, 2024 09:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file is massive, and can be broken up neatly into
This is prep work for #6581