Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: even more debug for test_secondary_downloads #7295

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Apr 3, 2024

The latest failures of test_secondary_downloads are spooky: layers are missing on disk according to the test, but present according to the pageserver logs:

  • Make the pageserver assert that layers are really present on disk and log the full path (debug mode only)
  • Make the test dump a full listing on failure of the assert that failed the last two times

Related: #6966

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Apr 3, 2024
@jcsp jcsp requested a review from a team as a code owner April 3, 2024 09:31
@jcsp jcsp requested a review from arpad-m April 3, 2024 09:31
Copy link

github-actions bot commented Apr 3, 2024

2748 tests run: 2609 passed, 0 failed, 139 skipped (full report)


Code coverage* (full report)

  • functions: 28.3% (6380 of 22554 functions)
  • lines: 47.2% (44982 of 95310 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4b56dd3 at 2024-04-03T10:16:27.163Z :recycle:

@jcsp jcsp merged commit bc05d7e into main Apr 3, 2024
56 checks passed
@jcsp jcsp deleted the jcsp/issue-6966-more-debug branch April 3, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants