Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm-monitor: collect lfc stats from vm-monitor #7302

Closed
wants to merge 1 commit into from
Closed

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Apr 3, 2024

Problem

We do not have LFC metrics for autoscaling.

Summary of changes

This pull request adds a prometheus metrics endpoint for all LFC metrics. The LFC metrics are refreshed every 5 seconds.

Alternative: we can push the data over websocket, or collect the data when a client accesses /metrics instead of for a given interval.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Apr 3, 2024

2754 tests run: 2630 passed, 0 failed, 124 skipped (full report)


Code coverage* (full report)

  • functions: 28.0% (6404 of 22875 functions)
  • lines: 46.8% (45074 of 96238 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
393f323 at 2024-04-05T16:31:17.470Z :recycle:

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh marked this pull request as ready for review April 5, 2024 15:35
@skyzh skyzh requested a review from a team as a code owner April 5, 2024 15:35
@skyzh skyzh requested a review from sharnoff April 5, 2024 15:35
@skyzh
Copy link
Member Author

skyzh commented Apr 5, 2024

Need to set up vm-monitor to test the change, waiting CI for building the image

@sharnoff
Copy link
Member

sharnoff commented Apr 5, 2024

I think adding it to vm-monitor is probably not the way we want to go? — we already have LFC metrics available from sql-exporter. vm-monitor is running only when the autoscaler-agent is already successfully connected to it; it is more fragile than sql-exporter for that reason.
And either way, we need to add support to the autoscaler-agent to fetch LFC metrics, so we might as well get them from sql-exporter.

Maybe I'm missing something - happy to discuss, lmk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants