-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pageserver: improve readability of shard.rs #7330
Conversation
No tests were run or test report is not availableCode coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
124c054 at 2024-04-12T12:39:28.459Z :recycle: |
2ebbd72
to
79176a9
Compare
On a related note, I wonder why |
Co-authored-by: Arpad Müller <arpad-m@users.noreply.github.com>
I wanted to avoid exposing all the shard.rs content to modules that don't really talk to pageservers, as it's kind of a concept that's "owned" by the pageserver (at least, until the safekeeper becomes shard aware). In future it might be nice to define a crate for "foundational types" (or some better name) -- these ID types aren't really "utilities as such". |
No functional changes, this is a comments/naming PR.
While merging sharding changes, some cleanup of the shard.rs types was deferred.
In this PR:
is_zero
tois_shard_zero
to make clear that this method doesn't literally mean that the entire object is zeros, just that it refers to the 0th shard in a tenant.Closes: #6072
Checklist before requesting a review
Checklist before merging