Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pagebench): add aux file bench #7746

Merged
merged 6 commits into from
May 17, 2024
Merged

feat(pagebench): add aux file bench #7746

merged 6 commits into from
May 17, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented May 13, 2024

Problem

part of #7462

Summary of changes

This pull request adds two APIs to the pageserver management API: list_aux_files and ingest_aux_files. The aux file pagebench is intended to be used on an empty timeline because the data do not go through the safekeeper. LSNs are advanced by 8 for each ingestion, to avoid invariant checks inside the pageserver.

For now, I only care about space amplification / read amplification, so the bench is designed in a very simple way: ingest 10000 files, and I will manually dump the layer map to analyze.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from problame May 13, 2024 21:11
@skyzh skyzh requested a review from a team as a code owner May 13, 2024 21:11
@skyzh skyzh mentioned this pull request May 13, 2024
24 tasks
Copy link

github-actions bot commented May 13, 2024

3078 tests run: 2951 passed, 0 failed, 127 skipped (full report)


Flaky tests (3)

Postgres 15

  • test_compute_pageserver_connection_stress: release

Postgres 14

  • test_synthetic_size_while_deleting: debug
  • test_timeline_size_quota_on_startup: release

Code coverage* (full report)

  • functions: 31.3% (6382 of 20401 functions)
  • lines: 47.7% (48631 of 101897 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
f106bdd at 2024-05-17T20:11:49.253Z :recycle:

Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new pagebench isn't measuring anything, and the workload it applies isn't parametrizable via CLI. It seems quite incomplete to me.

I'm ok with merging it if you intend to extend it later, would be nice to link the follow-up issue for that.

Approval is subject to changing the POST API to testing_api_handler, I don't think it's safe to use if there's a concurrent other DatadirModifications.

pageserver/src/http/routes.rs Outdated Show resolved Hide resolved
pageserver/src/http/routes.rs Outdated Show resolved Hide resolved
pageserver/src/http/routes.rs Outdated Show resolved Hide resolved
pageserver/src/http/routes.rs Outdated Show resolved Hide resolved
pageserver/pagebench/src/cmd/aux_files.rs Outdated Show resolved Hide resolved
pageserver/client/src/mgmt_api.rs Outdated Show resolved Hide resolved
pageserver/pagebench/src/cmd/aux_files.rs Show resolved Hide resolved
pageserver/pagebench/src/cmd/aux_files.rs Outdated Show resolved Hide resolved
skyzh added 2 commits May 17, 2024 10:13
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/pagebench-aux-files branch from 14f5803 to df34c0a Compare May 17, 2024 14:17
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/pagebench-aux-files branch from df34c0a to 1dc17e0 Compare May 17, 2024 14:22
skyzh and others added 2 commits May 17, 2024 10:49
@skyzh skyzh enabled auto-merge (squash) May 17, 2024 19:03
@skyzh skyzh merged commit e1a9669 into main May 17, 2024
50 checks passed
@skyzh skyzh deleted the skyzh/pagebench-aux-files branch May 17, 2024 20:04
a-masterov pushed a commit that referenced this pull request May 20, 2024
part of #7462

## Summary of changes

This pull request adds two APIs to the pageserver management API:
list_aux_files and ingest_aux_files. The aux file pagebench is intended
to be used on an empty timeline because the data do not go through the
safekeeper. LSNs are advanced by 8 for each ingestion, to avoid
invariant checks inside the pageserver.

For now, I only care about space amplification / read amplification, so
the bench is designed in a very simple way: ingest 10000 files, and I
will manually dump the layer map to analyze.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants