Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tense of errors #8234

Merged
merged 1 commit into from
Jul 2, 2024
Merged

tense of errors #8234

merged 1 commit into from
Jul 2, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Jul 2, 2024

I forgot a commit when merging #8177

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Jul 2, 2024
@jcsp jcsp requested a review from problame July 2, 2024 15:05
Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you had added one thiserror somewhere that was using present progressive

Copy link

github-actions bot commented Jul 2, 2024

3000 tests run: 2885 passed, 0 failed, 115 skipped (full report)


Code coverage* (full report)

  • functions: 32.7% (6936 of 21213 functions)
  • lines: 50.0% (54330 of 108576 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
cf285d6 at 2024-07-02T15:57:58.828Z :recycle:

@jcsp jcsp marked this pull request as ready for review July 2, 2024 16:17
@jcsp jcsp requested a review from a team as a code owner July 2, 2024 16:17
@jcsp jcsp requested a review from skyzh July 2, 2024 16:17
@jcsp jcsp merged commit f583232 into main Jul 2, 2024
69 checks passed
@jcsp jcsp deleted the jcsp/fatal-io-errors-in-config branch July 2, 2024 16:17
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
I forgot a commit when merging
#8177
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
I forgot a commit when merging
#8177
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
I forgot a commit when merging
#8177
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
I forgot a commit when merging
#8177
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
I forgot a commit when merging
#8177
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
I forgot a commit when merging
#8177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants