Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: remove absolute-order disk usage eviction #8454

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Jul 22, 2024

Problem

Deployed pageserver configurations are all like this:

      disk_usage_based_eviction:
        max_usage_pct: 85
        min_avail_bytes: 0
        period: "10s"
        eviction_order:
          type: "RelativeAccessed"
          args:
            highest_layer_count_loses_first: true

But we're maintaining this optional absolute order eviction, with test cases etc.

Summary of changes

  • Remove absolute order eviction. Make the default eviction policy the same as how we really deploy pageservers.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Jul 22, 2024
@jcsp jcsp requested a review from koivunej July 22, 2024 10:42
@jcsp jcsp marked this pull request as ready for review July 22, 2024 10:57
@jcsp jcsp requested a review from a team as a code owner July 22, 2024 10:57
@jcsp jcsp requested a review from problame July 22, 2024 10:57
@jcsp jcsp enabled auto-merge (squash) July 22, 2024 10:57
Copy link

3114 tests run: 2993 passed, 0 failed, 121 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_scrubber_physical_gc_ancestors[2]: release

Code coverage* (full report)

  • functions: 32.6% (7000 of 21461 functions)
  • lines: 50.0% (55274 of 110514 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2f14bb8 at 2024-07-22T11:28:48.974Z :recycle:

@jcsp jcsp merged commit 98af1e3 into main Jul 22, 2024
69 checks passed
@jcsp jcsp deleted the jcsp/remove-abs-eviction-order branch July 22, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants