Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: simplify code around unstable test_basebackup_with_high_slru_count #8477

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Jul 23, 2024

Problem

In test_basebackup_with_high_slru_count, the pageserver is sometimes mysteriously hanging on startup, having been started+stopped earlier in the test setup while populating template tenant data.

We can't see why this is hanging in this particular test. The test does some weird stuff though, like attaching a load of broken tenants and then doing a SIGQUIT kill of a pageserver.

Summary of changes

  • Attach tenants normally instead of doing a failpoint dance to attach them as broken
  • Shut the pageserver down gracefully during init instead of using immediate mode
  • Remove the "sequential" variant of the unstable test, as this is going away soon anyway
  • Log before trying to acquire lock file, so that if it hangs we have a clearer sense of if that's really where it's hanging. It seems like it is, but that code does a non-blocking flock so it's surprising.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added a/test Area: related to testing a/tech_debt Area: related to tech debt run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label labels Jul 23, 2024
@jcsp jcsp changed the title Jcsp/issue 7586 simplify tests: simplify code around unstable test_basebackup_with_high_slru_count Jul 23, 2024
@jcsp jcsp requested a review from VladLazar July 24, 2024 07:18
@jcsp jcsp marked this pull request as ready for review July 24, 2024 07:18
@jcsp jcsp requested a review from a team as a code owner July 24, 2024 07:18
Copy link

3213 tests run: 3080 passed, 0 failed, 133 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_compaction_induced_by_detaches_in_history: release

Code coverage* (full report)

  • functions: 32.6% (7003 of 21497 functions)
  • lines: 50.0% (55265 of 110587 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
189a097 at 2024-07-24T08:34:14.803Z :recycle:

@jcsp jcsp merged commit 842c3d8 into main Jul 24, 2024
76 of 79 checks passed
@jcsp jcsp deleted the jcsp/issue-7586-simplify branch July 24, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt a/test Area: related to testing run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants