Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PG17's extension modifications #9010

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix PG17's extension modifications #9010

merged 1 commit into from
Sep 16, 2024

Conversation

MMeent
Copy link
Contributor

@MMeent MMeent commented Sep 16, 2024

This also reduces the GRANT statements to one per created _reset function

Problem

Currently, we can't start PG17 computes because installing pg_stat_statements v1.11 fails, with error function pg_stat_statements_reset(oid, oid, bigint) does not exist. That's correct, because the function signature changed to pg_stat_statements_reset(oid, oid, bigint, boolean) in pg17.

Our image building code didn't take that into account yet, so here's a modification to support that.

Summary of changes

Improve this extension-modifying code to support p_s_s_r(oid, oid, bigint, boolean), and do the extension modifications in a more streamlined fashion.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@MMeent MMeent enabled auto-merge (squash) September 16, 2024 12:35
This also reduces the GRANT statements to one per created _reset function
Copy link

github-actions bot commented Sep 16, 2024

4994 tests run: 4830 passed, 0 failed, 164 skipped (full report)


Flaky tests (9)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

  • test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64

Code coverage* (full report)

  • functions: 31.8% (7416 of 23294 functions)
  • lines: 49.9% (59584 of 119380 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0b089c4 at 2024-09-16T15:34:42.474Z :recycle:

@MMeent MMeent merged commit c8bedca into main Sep 16, 2024
82 checks passed
@MMeent MMeent deleted the fix/extension-mods-pg17 branch September 16, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants