Little python test cleanup #9018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hlinnaka
commented
Sep 16, 2024
hlinnaka
commented
- Remove a few unused / redundant functions
- Move functions related to auth tokens to separate python file. For readability; neon_fixtures.py is huge.
- Mark a few fixtures as session-scoped
4968 tests run: 4804 passed, 0 failed, 164 skipped (full report)Flaky tests (3)Postgres 17
Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
3f2ba6a at 2024-09-17T00:31:40.152Z :recycle: |
tristan957
approved these changes
Sep 16, 2024
hlinnaka
force-pushed
the
misc-test-cleanup
branch
3 times, most recently
from
f856d29
to
4f71386
Compare
hlinnaka
added a commit
that referenced
this pull request
Sep 16, 2024
hlinnaka
added a commit
that referenced
this pull request
Sep 16, 2024
There was another copy of it in utils.py. The only difference is that the version in utils.py tolerates files that are concurrently removed. That seems fine for the few callers in neon_fixtures.py too.
hlinnaka
added a commit
that referenced
this pull request
Sep 16, 2024
pg_distrib_dir doesn't include the Postgres version and only depends on env variables which cannot change during a test run, so it can be marked as session-scoped. Similarly, the platform cannot change during a test run.
hlinnaka
force-pushed
the
misc-test-cleanup
branch
from
4f71386
to
ffd079f
Compare
hlinnaka
added a commit
that referenced
this pull request
Sep 16, 2024
There was another copy of it in utils.py. The only difference is that the version in utils.py tolerates files that are concurrently removed. That seems fine for the few callers in neon_fixtures.py too.
hlinnaka
added a commit
that referenced
this pull request
Sep 16, 2024
pg_distrib_dir doesn't include the Postgres version and only depends on env variables which cannot change during a test run, so it can be marked as session-scoped. Similarly, the platform cannot change during a test run.
hlinnaka
force-pushed
the
misc-test-cleanup
branch
from
ffd079f
to
f4e7292
Compare
This is in preparation of replacing neon_fixtures.get_dir_size with neon_fixtures.utils.get_dir_size() in next commit.
There was another copy of it in utils.py. The only difference is that the version in utils.py tolerates files that are concurrently removed. That seems fine for the few callers in neon_fixtures.py too.
pg_distrib_dir doesn't include the Postgres version and only depends on env variables which cannot change during a test run, so it can be marked as session-scoped. Similarly, the platform cannot change during a test run.
hlinnaka
force-pushed
the
misc-test-cleanup
branch
from
f4e7292
to
3f2ba6a
Compare
|
Went ahead and kicked your CI for you. |
hlinnaka
added a commit
that referenced
this pull request
Sep 17, 2024
hlinnaka
added a commit
that referenced
this pull request
Sep 17, 2024
This is in preparation of replacing neon_fixtures.get_dir_size with neon_fixtures.utils.get_dir_size() in next commit.
hlinnaka
added a commit
that referenced
this pull request
Sep 17, 2024
There was another copy of it in utils.py. The only difference is that the version in utils.py tolerates files that are concurrently removed. That seems fine for the few callers in neon_fixtures.py too.
hlinnaka
added a commit
that referenced
this pull request
Sep 17, 2024
pg_distrib_dir doesn't include the Postgres version and only depends on env variables which cannot change during a test run, so it can be marked as session-scoped. Similarly, the platform cannot change during a test run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.